• src/sbbs3/sbbsecho.c

    From rswindell@1:103/705 to CVS commit on Wed Jul 15 21:11:55 2020
    src/sbbs3 sbbsecho.c 3.173 3.174
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv22900

    Modified Files:
    sbbsecho.c
    Log Message:
    If an export netmail message has MSGID/REPLY header fields, add those as kludges (needed for including message-IDs in exported netmail).

    --- SBBSecho 3.11-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From rswindell@1:103/705 to CVS commit on Sat Jul 18 20:42:28 2020
    src/sbbs3 sbbsecho.c 3.174 3.175
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv1776

    Modified Files:
    sbbsecho.c
    Log Message:
    Extra log level message (INFO, WARNING, and DEBUG) when moving netamil file attachments (attached files) - for debugging the issue reported by
    alterego (ALTERANT)

    --- SBBSecho 3.11-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From rswindell@1:103/705 to CVS commit on Sun Jul 19 11:50:39 2020
    src/sbbs3 sbbsecho.c 3.175 3.176
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv10832

    Modified Files:
    sbbsecho.c
    Log Message:
    import_netmail(): Safer string handline and a bit more/consistent log output around attached file handling (especially if mv() fails).

    --- SBBSecho 3.11-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to Git commit to sbbs/master on Thu Sep 24 20:20:57 2020
    https://gitlab.synchro.net/sbbs/sbbs/-/commit/57afc83c4a58a1a7f6af05ee
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Signal the sub-board's configured semaphore file when importing echomailAt the request of alterego (ALTERANT), if a sub-board has a "post semaphore"configured, signal (touch) it whenever a message is imported via SBBSecho intothat sub-board.
    --- SBBSecho 3.11-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to Git commit to sbbs/master on Thu Sep 24 20:34:10 2020
    https://gitlab.synchro.net/sbbs/sbbs/-/commit/ddba8d7cec9cd0367d7e0480
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Fix previous commit: we need to use mycmdstr(), not cmdstr().
    --- SBBSecho 3.11-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to Git commit to sbbs/master on Fri Sep 25 17:57:04 2020
    https://gitlab.synchro.net/sbbs/sbbs/-/commit/da486a78c63293a86718c78d
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Don't attempt to parse origin addr from origin lines in NetMail msgsApparently, some versions or configurations of Mystic BBS will include anOrigin Line in FTN NetMail messages. That would've been okay for SBBSecho,except these origin lines do not contain an FTN address (in parenthesis).So, firstly: when importing NetMail messages (subnum=INVALID_SUB), don'tattempt to parse any Origin Lines. Secondly, fix up the Origin Line parsecode a bit better detect the case when no FTN address is actually present.
    --- SBBSecho 3.11-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to Git commit to sbbs/master on Fri Nov 20 21:38:16 2020
    https://gitlab.synchro.net/sbbs/sbbs/-/commit/6380257eb617c61048195583
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Support forwarding FTN netmail to user's forward-to netmail addressThere's no new opt-in option for this new feature - maybe there should be.For geneb.
    --- SBBSecho 3.11-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to Git commit to sbbs/master on Sat Nov 21 12:18:30 2020
    https://gitlab.synchro.net/sbbs/sbbs/-/commit/796c3db7d2e5fdb81b1c4dff
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    A better check of a user's netmail-forwarding address.is_supported_netmail_addr() actually takes the system configuration and QWK routing table into account. No sense forwarding to a non-deliverable address.
    --- SBBSecho 3.11-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to Git commit to sbbs/master on Sat Nov 21 12:59:53 2020
    https://gitlab.synchro.net/sbbs/sbbs/-/commit/efbb1b5d5577a05515f1f6e5
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Revert "A better check of a user's netmail-forwarding address."This reverts commit 796c3db7d2e5fdb81b1c4dff884e15d66718063c.
    --- SBBSecho 3.11-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to Git commit to sbbs/master on Sun Nov 22 14:28:50 2020
    https://gitlab.synchro.net/sbbs/sbbs/-/commit/cbda86ec8738498c14ae87fb
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Fix netmail forwarding (new feature)The recipient net-addr/type was always being over-ridden a bit further down in the code. Don't do that.Also, log a message (sbbsecho.log) indicating that a message was forwarded ("Forwarding message ...").For geneb.
    --- SBBSecho 3.11-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to Git commit to main/sbbs/master on Wed Dec 9 22:29:28 2020
    https://gitlab.synchro.net/main/sbbs/-/commit/a1e127841841087fb51e1c32
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Don't repeate mail "comment" headers in exported netmail msgssmb_getmsgtxt() returns any "comment" headers as part of the message body text, and has since 2003.When I added mail->netmail (stored message) export support to SBBSecho v3, I duplicated this logic, so comment headers were added *twice* to exported netmail messages. Oops. I didn't notice until today when playing with forwarding-to-netmail (FTN).Also noticed and fixed: any comment headers in posted messages (unlikely/uncommon) would not be exported to EchoMail messages. Use the correct smb_getmsgtxt() mode flags ("NO_TAILS" instead of "BODY_ONLY") - I know, not great names.
    --- SBBSecho 3.11-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to Git commit to main/sbbs/master on Thu Dec 24 16:28:13 2020
    https://gitlab.synchro.net/main/sbbs/-/commit/c590c437c7dee6de8531217b
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Use QWKnet ID of originating system when imported via QWKnetUpdate to previous commit.
    --- SBBSecho 3.11-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to Git commit to main/sbbs/master on Sun Feb 14 17:17:59 2021
    https://gitlab.synchro.net/main/sbbs/-/commit/53d3103177986398c19564a3
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    When replying to PING netmails, use the destination addr as the origaddrAs tested and reported in FIDONEWS by Michiel van der Vlist, 2:280/5555, SBBSecho would use the "best match" FidoNet AKA for the originating address when replying to PING netmail messages and not necessarily the original destination address of the ping request. For systems that have multiple addresses (AKAs) that could be considered appropriate originating addresses for the requesting node address (e.g. multiple addresses in the same zone or zone/net), this could cause a confusion for the PING requester.The create_netmail() function now accepts an optional source (orig) address parameter and the PING response logic passes the netmail's destination address for the reply message's originating (source) address.I noticed that AreaMgr responses also follow the same logic as PING responses (just use the best-fit AKA, not necessarily the same address as the original request's destination address) - but I did not choose to address that "issue" at this time.
    --- SBBSecho 3.12-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to Git commit to main/sbbs/master on Sun Feb 21 19:25:49 2021
    https://gitlab.synchro.net/main/sbbs/-/commit/a9967b46fc2be2e0d08efb49
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Fix memcmp() usage problem introduced in previous commitCaught by GCC.
    --- SBBSecho 3.13-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to Git commit to main/sbbs/master on Mon Feb 22 00:27:34 2021
    https://gitlab.synchro.net/main/sbbs/-/commit/a1bead7cc4e295514a5c1b18
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Eliminate a large pass-struct-by-valueCaught by Coverity.
    --- SBBSecho 3.13-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to Git commit to main/sbbs/master on Mon Feb 22 14:44:06 2021
    https://gitlab.synchro.net/main/sbbs/-/commit/160606e4ce35305a55819266
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Print error and return NULL from getfmsg() upon ftell errorCaught by Coverity - ftell[o] can return negative.
    --- SBBSecho 3.13-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to Git commit to main/sbbs/master on Sun Apr 4 13:38:22 2021
    https://gitlab.synchro.net/main/sbbs/-/commit/f3e4a6e498c8c206e087da88
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Use SAFECAT() instead of strcat() for more safety.
    --- SBBSecho 3.14-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to Git commit to main/sbbs/master on Thu May 20 02:48:11 2021
    https://gitlab.synchro.net/main/sbbs/-/commit/1031d0f6e01686c5a8dda583
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Replace tempnam() usage with the suggested mkstemp()Since we're cleaning up warnings... this will break the Windows build for now.
    --- SBBSecho 3.14-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to Git commit to main/sbbs/master on Sat May 29 19:32:50 2021
    https://gitlab.synchro.net/main/sbbs/-/commit/0f262d8ab2a6bd870adbb428
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Don't allow downlinks (AreaFix add) of our "Unknown echoes" sub-boardIt was recently pointed out to me that a downlink could link to the '*' echo via Area Manager (AreaFix) request. This was not intentional.
    --- SBBSecho 3.14-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to Git commit to main/sbbs/master on Sat May 29 20:12:09 2021
    https://gitlab.synchro.net/main/sbbs/-/commit/7f0390149d84d79a3b7bfb10
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Keep the same area file (areas.bbs) mode flags (permissions)When executing area manager requests that alter the area file, the temp areafile created (with mkstemp) had mode 0600 (owner read/write only). The sysopvery possibly had different permission flags they want to keep for their areafile, so copy the mode flags from the original area file to the temp/new areafile.
    --- SBBSecho 3.14-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to Git commit to main/sbbs/master on Sat May 29 20:16:25 2021
    https://gitlab.synchro.net/main/sbbs/-/commit/9a8c8e6d414c2bfe503aa841
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Microsoft doesn't have fchmod(), so use chmod() on the closed file
    --- SBBSecho 3.14-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to Git commit to main/sbbs/master on Wed Oct 6 18:38:09 2021
    https://gitlab.synchro.net/main/sbbs/-/commit/ccc0e4019838ce4021c16b0e
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    When packing netmail (stored messages), don't discard non-zero zonesAs reported by Ragnarok (DOCKSUD) via DOVE-Net, when packing (packetizing) netmail messages, the source and destination zones from the netmail header were discarded (since they are defined as "optional" in FTS-1) and the zone values were replaced with the system's primary/default zone number. If the netmail message included an INTL kludge, the source and destination zone values would be parsed from that kludge line and this issue would not be noticed. So the fix is: Only if the netmail message header contains a source or destination zone number of 0, replace that zone with the system's primary/default zone number. As before, the INTL kludge zone information can override the header fields.Also, there's no reason to force the point numbers from the header to zero, since if they were not valid (e.g. "fill" in the original FTS-1 specification), they would be already zero. So use the source and destination point numbers, as is, from the netmail header too (with the FMPT and TOPT kludge override support left in-tact).
    --- SBBSecho 3.14-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to Git commit to main/sbbs/master on Thu Nov 11 18:43:46 2021
    https://gitlab.synchro.net/main/sbbs/-/commit/5012efb1eb3d2d20289a01c1
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Log an error and exit immediately when a local linked-node is configuredWhen a linked-node (in echocfg->Linked Nodes) contains one of the local system's FTN addresses, display/log an error and exit immediately, e.g.:Configuration ERROR: Linked node #20 is your own address: 1:103/705I'd perform this check in EchoCfg, but:1. echocfg doesn't read the BBS's configuration files (where the local FTN addresses are configured), and2. some sysops just directly edit their sbbsecho.ini file
    --- SBBSecho 3.14-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to Git commit to main/sbbs/master on Fri Nov 12 14:09:35 2021
    https://gitlab.synchro.net/main/sbbs/-/commit/e10b39d1aee183a16a3d9458
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Generate a MSGID kludge for netmail messages created by SBBSechoThe "serialno" field is a bad/naive one (a time_t value), but this is really just an experiment for Ragnarok to see if this fixes issue #306 (with hotdoged receiving AreaFix responses/notices).
    --- SBBSecho 3.14-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to Git commit to main/sbbs/master on Thu Nov 18 17:38:10 2021
    https://gitlab.synchro.net/main/sbbs/-/commit/27dfa4f6b9ebc59e1c4f097e
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Resolve gcc warningwarning: format ‘%lx’ expects argument of type ‘long unsigned int’
    --- SBBSecho 3.14-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)