• src/sbbs3/main.cpp

    From rswindell@1:103/705 to CVS commit on Sun Jul 19 21:12:22 2020
    src/sbbs3 main.cpp 1.790 1.791
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv13583

    Modified Files:
    main.cpp
    Log Message:
    Don't display full path (just the filename) of errored JS file to user.

    --- SBBSecho 3.11-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to Git commit to sbbs/master on Sun Aug 23 17:50:06 2020
    https://gitlab.synchro.net/sbbs/sbbs/-/commit/b105d77749607d5bc8dacc99
    Modified Files:
    src/sbbs3/main.cpp
    Log Message:
    Lower log level of the "Perhaps node is already runnnig" log msg from ERR to WARN
    --- SBBSecho 3.11-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to Git commit to sbbs/master on Thu Sep 3 22:29:28 2020
    https://gitlab.synchro.net/sbbs/sbbs/-/commit/8bf25ec78bdcf404e0ddab27
    Modified Files:
    src/sbbs3/main.cpp
    Log Message:
    Lower the SSH-related log message severities to WARNING for SSH connections
    --- SBBSecho 3.11-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to Git commit to sbbs/master on Sat Sep 19 22:33:42 2020
    https://gitlab.synchro.net/sbbs/sbbs/-/commit/9bf4b7bba19d951f3ca48c96
    Modified Files:
    src/sbbs3/main.cpp
    Log Message:
    Don't send telnet commands to spy socketssend_telnet_cmd() now sends telnet commands/replies directly to the clientsocket. This avoid the entire output_thread() teeing of sent data to spysockets/buffers (which may not be Telnet at all).There are some concerns with this change:- if client_socket isn't writable, will sendsocket() block?- if output_thread is sending on the same socket, are our 2/3-byte telnet commands going to have other output data interleaved within? (seems very unlikely)
    --- SBBSecho 3.11-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to Git commit to sbbs/master on Sat Sep 19 23:04:07 2020
    https://gitlab.synchro.net/sbbs/sbbs/-/commit/cbdb2b494c85d24a7b3b887b
    Modified Files:
    src/sbbs3/main.cpp
    Log Message:
    Move the "connect" spy message to where the hostname and IP address are known --- SBBSecho 3.11-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to Git commit to sbbs/master on Fri Oct 23 01:51:57 2020
    https://gitlab.synchro.net/sbbs/sbbs/-/commit/ec6d7e3edf557779be7e54cd
    Modified Files:
    src/sbbs3/main.cpp
    Log Message:
    Don't count guest logins as authenticated connections...When enforcing the MaxConcurrentConnections limit, don't count connections for user's with blank passwords (i.e. Guest) as authenticated.
    --- SBBSecho 3.11-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to Git commit to sbbs/master on Wed Nov 4 23:28:33 2020
    https://gitlab.synchro.net/sbbs/sbbs/-/commit/3a19853b763f35a22ece717c
    Modified Files:
    src/sbbs3/main.cpp
    Log Message:
    Address 32-bit GCC warning about printf format'%lu' expects argument of type 'long unsigned int', but argument 5 has type 'off_t
    --- SBBSecho 3.11-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to Git commit to sbbs/master on Fri Nov 13 00:24:17 2020
    https://gitlab.synchro.net/sbbs/sbbs/-/commit/bd78d5c5725843afc6659822
    Modified Files:
    src/sbbs3/main.cpp
    Log Message:
    Add timestamp of node.log file to crash.logWhen a preexisting node.log file is found, a terminal server crash is suspected. Include the timestamp of the node.log in the message appended to the system log (data/logs/*.log) to help identify the likely time of the crash.
    --- SBBSecho 3.11-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Deon George@1:103/705 to Git commit to sbbs/master on Sun Nov 22 00:35:59 2020
    https://gitlab.synchro.net/sbbs/sbbs/-/commit/6d0ec492cd2a5db51e416548
    Modified Files:
    src/sbbs3/main.cpp
    Log Message:
    Ooops, forgot to make btox static
    --- SBBSecho 3.11-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Deon George@1:103/705 to Git commit to sbbs/master on Sun Nov 22 00:35:59 2020
    https://gitlab.synchro.net/sbbs/sbbs/-/commit/db690fadea6237739f73825c
    Modified Files:
    src/sbbs3/main.cpp
    Log Message:
    Improve btox() so that it doesnt lead to any buffer overruns
    --- SBBSecho 3.11-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Digital Man@1:103/705 to Deon George on Sun Nov 22 13:23:45 2020
    Re: src/sbbs3/main.cpp
    By: Deon George to Git commit to sbbs/master on Sun Nov 22 2020 12:35 am

    https://gitlab.synchro.net/sbbs/sbbs/-/commit/6d0ec492cd2a5db51e416548 Modified Files:
    src/sbbs3/main.cpp
    Log Message:
    Ooops, forgot to make btox static

    Oops, I forgot to squash this giant merge. <grimmace>
    --
    digital man

    Rush quote #64:
    He's cleaning up his systems to keep his nature pure .. New World Man
    Norco, CA WX: 75.9øF, 29.0% humidity, 6 mph NNE wind, 0.00 inches rain/24hrs --- SBBSecho 3.11-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to Git commit to main/sbbs/master on Sun Nov 29 00:31:28 2020
    https://gitlab.synchro.net/main/sbbs/-/commit/82d3ae6e61d8876d35444bdf
    Modified Files:
    src/sbbs3/main.cpp
    Log Message:
    Load/keep/refresh each node's configuration in memory.Previously, all nodes shared the same copy of the configuration in memory. This prevented any node from seeing an updated configuration until all nodes were offline or waiting for connection and could be recycled. Now, no recycling of the server is needed for a node to load a new config. A node in-use *still* cannot reload configuration until the user disconnects, but all you have to do is logon to another unused node and you (or that user) will get an updated configuration. Bots or server recycling problems will no longer prevent the sysop or user from getting a current configuration when connecting to any node.This is one of those instances of giving the sysop what he wants rather than what he asked for. I should've done this a long time ago, but the idea just occurred to me. You're welcome. :-)
    --- SBBSecho 3.11-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to Git commit to main/sbbs/master on Sun Nov 29 11:40:10 2020
    https://gitlab.synchro.net/main/sbbs/-/commit/827063bb1d4343e145a85ffa
    Modified Files:
    src/sbbs3/main.cpp
    Log Message:
    Copy event last-run info from global config into node configFixes issue introduced in last commit to this file (the each-node-has-its-own-config-in-memory enhancement) that would prevent users from logging in because their time was reduced for an upcoming event that had already run. The change assumes the event thread is running (its the thing that reads the event last-run info from time.dab). Thanks to mlong for the report.
    --- SBBSecho 3.11-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to Git commit to main/sbbs/master on Sun Nov 29 12:28:05 2020
    https://gitlab.synchro.net/main/sbbs/-/commit/07bd3442362ada96e99a4294
    Modified Files:
    src/sbbs3/main.cpp
    Log Message:
    Fallback to the "first node" configurationIf a node's configuration can't be loaded (e.g. nodeX/node.cnf is missing), fall-back and load the "first node" (e.g. Node1) configuration. On recent *nix installs (since the migration to Git), the node2+/node.cnf files were not copied/created, so let's solve that soon-to-be-FAQ now.
    --- SBBSecho 3.11-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to Git commit to main/sbbs/master on Sun Nov 29 13:10:58 2020
    https://gitlab.synchro.net/main/sbbs/-/commit/656bdb8fe79786b94f7dc5ac
    Modified Files:
    src/sbbs3/main.cpp
    Log Message:
    Log a warning when falling-back the loaded node configuration.
    --- SBBSecho 3.11-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Bob Roberts@1:103/705 to Rob Swindell on Sun Nov 29 12:45:15 2020
    Re: src/sbbs3/main.cpp
    By: Rob Swindell to Git commit to main/sbbs/master on Sun Nov 29 2020 12:31 am

    another unused node and you (or that user) will get an updated configuration. Bots or server recycling
    problems will no longer prevent the sysop or user from getting a current configuration when connecting
    to any node.

    This is one of those instances of giving the sysop what he wants rather than what he asked for. I
    should've done this a long time ago, but the idea just occurred to me. You're welcome. :-)

    This is freaking awesome. Thanks DM!

    |01bobbobbobbob|09bob|03bob|11bob|03bob|09bob|01bobbobbob |01robrobrobrob|09rob|03rob|11rob|03rob|09rob|01robrobrob
    |07

    ---
    þ Synchronet þ Halls of Valhalla =San=Francisco= Happy Holidays
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to Git commit to main/sbbs/master on Sun Dec 6 20:21:13 2020
    https://gitlab.synchro.net/main/sbbs/-/commit/d9ea54258ab2a39b3e71bdcf
    Modified Files:
    src/sbbs3/main.cpp
    Log Message:
    Don't create a JS "client" object for timed eventsThere is no actual TCP-client when a timed event is executing, so don't create one in the JS context when the socket is invalid.
    --- SBBSecho 3.11-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to Git commit to main/sbbs/master on Sun Dec 13 02:00:30 2020
    https://gitlab.synchro.net/main/sbbs/-/commit/0d8ea19e309c6afd80a587c8
    Modified Files:
    src/sbbs3/main.cpp
    Log Message:
    Create node#/client.ini for each node client connectionPaves the way for utilities like umonitor to show client details for node connections (e.g. IP address, hostname, connection duration, etc.)
    --- SBBSecho 3.11-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to Git commit to main/sbbs/master on Sat Dec 19 16:09:15 2020
    https://gitlab.synchro.net/main/sbbs/-/commit/5e46cb0f6cc44b2176c97b0f
    Modified Files:
    src/sbbs3/main.cpp
    Log Message:
    Additional/optional 'mode' argument to global prompt() methodDefaults to K_EDIT.
    --- SBBSecho 3.11-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to Git commit to main/sbbs/master on Sun Feb 21 19:38:20 2021
    https://gitlab.synchro.net/main/sbbs/-/commit/4187942a94aeb8489a4a1371
    Modified Files:
    src/sbbs3/main.cpp
    Log Message:
    Fix build issue on *nix with the new protected int destroy macros.
    --- SBBSecho 3.13-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to Git commit to main/sbbs/master on Mon Feb 22 00:27:34 2021
    https://gitlab.synchro.net/main/sbbs/-/commit/8fabcdf19acb64f684922f68
    Modified Files:
    src/sbbs3/main.cpp
    Log Message:
    Use the CopyFile() function when moving files.This function is the fastest file-copy method (or should be), but does not have any progress indication.
    --- SBBSecho 3.13-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to Git commit to main/sbbs/master on Fri Mar 5 20:41:25 2021
    https://gitlab.synchro.net/main/sbbs/-/commit/f4d33f43cc1326150c82e100
    Modified Files:
    src/sbbs3/main.cpp
    Log Message:
    Don't leave the logged event code as "DAILY" after daily events runI noticed "DAILY ... Semaphore signaled" in the event thread log output. Now fixed.
    --- SBBSecho 3.13-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Deucе@1:103/705 to Git commit to main/sbbs/master on Mon Mar 15 00:16:56 2021
    https://gitlab.synchro.net/main/sbbs/-/commit/5bb4bcc4a60fd2b03ca2efe8
    Modified Files:
    src/sbbs3/main.cpp
    Log Message:
    Increase flush write timeout for SSH.During YModem-G transfers, the previous 5-second timeout wasexceeded.
    --- SBBSecho 3.13-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Deucе@1:103/705 to Git commit to main/sbbs/master on Mon Mar 15 00:52:25 2021
    https://gitlab.synchro.net/main/sbbs/-/commit/ffb202237f4fde4d79c407a2
    Modified Files:
    src/sbbs3/main.cpp
    Log Message:
    Changing timeout didn't help. Use PopData of zero bytes to rekey...This issue may actually be a rekey issue, to clear this, we needto call cryptPopData(), but we can pop zero bytes.In this case, re-try the flush.
    --- SBBSecho 3.13-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Deucе@1:103/705 to Git commit to main/sbbs/master on Mon Mar 15 01:11:15 2021
    https://gitlab.synchro.net/main/sbbs/-/commit/2e1cedadc9d93f2810cd9571
    Modified Files:
    src/sbbs3/main.cpp
    Log Message:
    Revert the last changes.Something weird is happening to the cryptlib session when SZ sendsa lot of data... no real clues left.
    --- SBBSecho 3.13-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Deucе@1:103/705 to Git commit to main/sbbs/master on Wed Mar 31 16:51:17 2021
    https://gitlab.synchro.net/main/sbbs/-/commit/8f0ae86b415a9e079ed1acfc
    Modified Files:
    src/sbbs3/main.cpp
    Log Message:
    Fix error in last commit.Looks like I was partially restoring old code before I stopped.
    --- SBBSecho 3.14-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to Git commit to main/sbbs/master on Sun Apr 4 15:13:57 2021
    https://gitlab.synchro.net/main/sbbs/-/commit/9c5205aa056dc04b0dd8e13e
    Modified Files:
    src/sbbs3/main.cpp
    Log Message:
    ftell() can return negative, dealCID 33232
    --- SBBSecho 3.14-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Deucе@1:103/705 to Git commit to main/sbbs/master on Mon Apr 5 01:13:34 2021
    https://gitlab.synchro.net/main/sbbs/-/commit/59bb0c3da6774ae5f9b405b1
    Modified Files:
    src/sbbs3/main.cpp
    Log Message:
    Spaces -> TabsTabs are the shit.
    --- SBBSecho 3.14-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Deucе@1:103/705 to Git commit to main/sbbs/master on Mon Apr 5 01:15:12 2021
    https://gitlab.synchro.net/main/sbbs/-/commit/9b14bb14cb24fb209a882e82
    Modified Files:
    src/sbbs3/main.cpp
    Log Message:
    MOAR!
    --- SBBSecho 3.14-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Deucе@1:103/705 to Git commit to main/sbbs/master on Mon Apr 5 01:25:04 2021
    https://gitlab.synchro.net/main/sbbs/-/commit/5bf7a8475ec4aa7ee88c37e3
    Modified Files:
    src/sbbs3/main.cpp
    Log Message:
    EVN MR!
    --- SBBSecho 3.14-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to Git commit to main/sbbs/master on Wed May 12 22:53:45 2021
    https://gitlab.synchro.net/main/sbbs/-/commit/3202b477e52faa34e6fa5666
    Modified Files:
    src/sbbs3/main.cpp
    Log Message:
    Attempt to resolve "!ERROR 11 receiving from socket" reported by plt<plt> May 13 00:39:40 sbbs synchronet: term Node 1 <plt> append key into keybuf: 4E (N)<plt> May 13 00:39:40 sbbs synchronet: term Node 1 <plt> Executing external: /sbbs/exec/sexyz 14 -Telnet sz /mnt/disk1/dl/COCO/AGI/agi-xmas.zip<plt> May 13 00:39:40 sbbs synchronet: term Node 1 <plt> sexyz: Synchronet External X/Y/ZMODEM v3.0 master/23b741a1c Copyright Rob Swindell<plt> May 13 00:39:40 sbbs synchronet: term Node 1 <plt> sexyz: !File skipped by receiver<plt> May 13 00:39:40 sbbs synchronet: term Node 1 <plt> sexyz: !File Skipped<plt> May 13 00:39:40 sbbs synchronet: term Node 1 <plt> sexyz: !0 Aborting Transfer (Sending ZABORT)<plt> May 13 00:39:40 sbbs synchronet: term Node 1 !ERROR 11 receiving from socket 14<plt> May 13 00:39:40 sbbs synchronet: term Node 1 input thread terminated (received 365 bytes in 35 blocks)Not sure why this isn't happening for other sysops - perhaps plt was spying on the node?
    --- SBBSecho 3.14-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to Git commit to main/sbbs/master on Sun May 16 16:47:09 2021
    https://gitlab.synchro.net/main/sbbs/-/commit/4a705a4667fea6e699d7965a
    Modified Files:
    src/sbbs3/main.cpp
    Log Message:
    Log local address in passthru connection failureAltere reported via IRC:!ERROR -1 (113) connecting to passthru socketIt might be helpful to know the address the passthru socket is bound to and the connection is being attempted on, so log that with the error.
    --- SBBSecho 3.14-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to Git commit to main/sbbs/master on Sun May 16 18:13:51 2021
    https://gitlab.synchro.net/main/sbbs/-/commit/54de9ce32a60a3ec38fcd41d
    Modified Files:
    src/sbbs3/main.cpp
    Log Message:
    Fix the printf format for the "ERROR ... connecting to passthru socket"Was passing the address string twice, so the port appeared as an invalid number.
    --- SBBSecho 3.14-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to Git commit to main/sbbs/master on Tue Jun 8 21:59:20 2021
    https://gitlab.synchro.net/main/sbbs/-/commit/31149a208abdd6cf12317cb4
    Modified Files:
    src/sbbs3/main.cpp
    Log Message:
    Always use rename() on *nix when mv() is called with copy=FALSEThis should fix issue #272 reported by Ragnarok. Not the libarchive error part, but the second (mv) CopyFile error part.
    --- SBBSecho 3.14-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to Git commit to main/sbbs/master on Fri Jun 11 11:29:25 2021
    https://gitlab.synchro.net/main/sbbs/-/commit/b093e0c714828fe1aae5a3f9
    Modified Files:
    src/sbbs3/main.cpp
    Log Message:
    Fix newly-introduced (but likely harmless) bug in mv()Thanks Coverity! (CID 332340)
    --- SBBSecho 3.14-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)