https://gitlab.synchro.net/main/sbbs/-/commit/380c33adbf3f1a62e24ab3b9
Modified Files:
docs/v322_new.md src/sbbs3/websrvr.cpp
Log Message:
Web Server: refuse HTTP authentication for a deleted or inactive account
check_ars() looked up the user named in an HTTP Basic or Digest
Authorization header and checked the password, but never the account's
status, so the right password logged in a deleted or inactive account.
An inactive account keeps its name, so it could log in by name; a
deleted one has its name removed from the name index, but with logins by
user number allowed (LOGIN_USERNUM) it could still log in by number.
Every other login path refuses such an account: the terminal server,
FTP, POP3, SMTP AUTH, and the JavaScript login() of the web server and Services.
Now such a login is refused like one with an unknown user, logged as
!DELETED or INACTIVE user, and counted as a failed login attempt against
the request's client. The password recorded with a failed HTTP
authentication (the Basic password, or "<digest>") comes from one
helper.
Tested on Linux against an isolated test server: HTTP Basic logins with
the right password for a deleted account and for an inactive one were
refused (401) and logged, and an active user's login still succeeded.
Co-Authored-By: Claude Opus 5.5 <
noreply@anthropic.com>
--- SBBSecho 3.38-Linux
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)