https://gitlab.synchro.net/main/sbbs/-/merge_requests/56#note_1144

mortifis and nelgin approved
--- SBBSecho 3.11-Linux
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

https://gitlab.synchro.net/main/sbbs/-/merge_requests/56#note_1149

What's the difference between SBBSCTRL and CTRLDIR here? Same question for all the other appear dupes (SBBSDATA, DATADIR, etc.). I'm not clear why we need both sets.
--- SBBSecho 3.11-Linux
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

https://gitlab.synchro.net/main/sbbs/-/merge_requests/56#note_1151

It looks like you're using `str[0]` as temporary state variable indicating if the file exists or not. This could be reduced to just:```if (!fexist(str)) {SAFEPRINTF(str,"%sdosemulaunch.ini",cfg.exec_dir);```You don't need these extra assignments and checking of `str[0]`.
--- SBBSecho 3.11-Linux
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

https://gitlab.synchro.net/main/sbbs/-/merge_requests/56#note_1153

Should this string be configurable too?
--- SBBSecho 3.11-Linux
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

https://gitlab.synchro.net/main/sbbs/-/merge_requests/56#note_1150

What's the significance of the '3' here? It's saying you want a string a least 3 characters in width. I would think single-digit node numbers should just be a single character.Also, the more correct way to do this would be to put the node number in a named_int_t list and pass that (instead of NULL) to the replace_named_values() function.
--- SBBSecho 3.11-Linux
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

https://gitlab.synchro.net/main/sbbs/-/merge_requests/56#note_1152

change `escape_seq` to a `const char*` and you won't need that typecat (`(char*)`) in xtrn.cpp.
--- SBBSecho 3.11-Linux
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

https://gitlab.synchro.net/main/sbbs/-/merge_requests/56#note_1154

They were pre-existing, I assumed they were env variables used by some native synchronet doors or something
--- SBBSecho 3.11-Linux
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

https://gitlab.synchro.net/main/sbbs/-/merge_requests/56#note_1155

Right, but "CTRLDIR" is new (introduced in this merge request). How is it different from SBBSCTRL?Maybe if you included an example of a generated external.bat file, we could see more clearly what's going on here.
--- SBBSecho 3.11-Linux
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

https://gitlab.synchro.net/main/sbbs/-/merge_requests/56#note_1156

Yes, here:SET DSZLOG=D:\PROTOCOL.LOGSET SBBSNODE=D:SET SBBSNNUM=1SET SBBSCTRL=F:SET SBBSDATA=G:SET SBBSEXEC=H:SET PCBNODE=1SET PCBDRIVE=D:SET PCBDIR=\SET XTRNDIR=\sbbs\xtrnSET CTRLDIR=\sbbs\ctrlSET DATADIR=\sbbs\dataSET EXECDIR=\sbbs\execSET NODEDIR=\sbbs\node1SET STARTDIR=bre
--- SBBSecho 3.11-Linux
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

https://gitlab.synchro.net/main/sbbs/-/merge_requests/56#note_1157

Okay, so none of these env variables are actually used in this batch file. Are they used in another batch file (i.e. maybe one that calls `lredir`)?
--- SBBSecho 3.11-Linux
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

https://gitlab.synchro.net/main/sbbs/-/merge_requests/56#note_1158

they are used`@ECHO OFFSET DSZLOG=D:\PROTOCOL.LOGSET SBBSNODE=D:SET SBBSNNUM=1SET SBBSCTRL=F:SET SBBSDATA=G:SET SBBSEXEC=H:SET PCBNODE=1SET PCBDRIVE=D:SET PCBDIR=\SET XTRNDIR=\sbbs\xtrnSET CTRLDIR=\sbbs\ctrlSET DATADIR=\sbbs\dataSET EXECDIR=\sbbs\execSET NODEDIR=\sbbs\node1SET STARTDIR=bre@unix -s NODEDIR@lredir D: linux\fs%NODEDIR% >NUL@lredir E: linux\fs%XTRNDIR% >NUL@lredir F: linux\fs%CTRLDIR% >NUL@lredir G: linux\fs%DATADIR% >NUL@lredir H: linux\fs%EXECDIR% >NULE:IF NOT "" == "%STARTDIR%" CD %STARTDIR%REM Optionally call emusetup.bat or put that stuff here for global (in NOEMU)REM Looks in startup dir, then ctrl dirIF EXIST EMUSETUP.BAT GOTO EMULOCALIF EXIST F:\EMUSETUP.BAT GOTO EMUGLOBALIF EXIST E:\DOSUTILS\NUL GOTO NOEMUECHO ERROR: No emusetup.bat in E:\%STARTDIR% or F, or E:\DOSUTILS\ is missingGOTO EXEC:EMULOCALCALL EMUSETUP.BATGOTO EXEC:EMUGLOBALCALL F:\EMUSETUP.BATGOTO EXEC:NOEMU@set PATH=%PATH%;E:\dosutilsunix -s RUNTYPEREM fossil driver, such as x00, bnu, or dosemu fossil.comrem IF "%RUNTYPE%" == "FOSSIL" @fossil.com >NULrem IF "%RUNTYPE%" == "FOSSIL" bnu.com /P1 /L0=11520 >NULIF "%RUNTYPE%" == "FOSSIL" x00.exe eliminate >NULREM share.exe for multinode file locking@share >NULGOTO EXEC:EXECbre scoreIF NOT "%1" == "TEST" exitemuREM For debugging: /usr/bin/env TERM=linux RUNTYPE=STDIO HOME=/sbbs/ctrl/ QUIET=1 DOSDRIVE_D=/sbbs/node1/ NODEDIR=/sbbs/node1/ /usr/bin/dosemu.bin -I"video { none }" -I'keystroke "\n"' -f/etc/dosemu/dosemu.conf -ED:external.bat -o/sbbs/node1/dosemu_boot.log >> /sbbs/data/dosevent_bre.log`
--- SBBSecho 3.11-Linux
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

Rob Swindell wrote to GitLab note in main/sbbs <=-

https://gitlab.synchro.net/main/sbbs/-/merge_requests/56#note_1151

It looks like you're using `str[0]` as temporary state variable
indicating if the file exists or not. This could be reduced to
just: ```
if (!fexist(str)) {
SAFEPRINTF(str,"%sdosemulaunch.ini",cfg.exec_dir);
```
You don't need these extra assignments and checking of `str[0]`.

Has this sub-board become JS_LESSONS?

I don't recall this kind of stuff in here until just recently, is all.



... All hope abandon, ye who enter messages here.
--- MultiMail/Linux v0.52
þ Synchronet þ Palantir BBS * palantirbbs.ddns.net * Pensacola, FL
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

Re: Re: Improvements to linux dosemu support
By: Gamgee to Rob Swindell on Thu Dec 10 2020 09:39 pm

Rob Swindell wrote to GitLab note in main/sbbs <=-

https://gitlab.synchro.net/main/sbbs/-/merge_requests/56#note_1151

It looks like you're using `str[0]` as temporary state variable indicating if the file exists or not. This could be reduced to
just: ```
if (!fexist(str)) {
SAFEPRINTF(str,"%sdosemulaunch.ini",cfg.exec_dir);
```
You don't need these extra assignments and checking of `str[0]`.

Has this sub-board become JS_LESSONS?

I don't recall this kind of stuff in here until just recently, is all.

It's new - gitlab integration with some dove-net subs. This is C++ code (part of a commit/merge request).
--
digital man

Sling Blade quote #2:
Karl (re: killing Doyle): I hit him two good whacks in the head with it.
Norco, CA WX: 50.9øF, 87.0% humidity, 0 mph S wind, 0.00 inches rain/24hrs
--- SBBSecho 3.11-Linux
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

Re: Re: Improvements to linux dosemu support
By: Digital Man to Gamgee on Thu Dec 10 2020 09:34 pm

It's new - gitlab integration with some dove-net subs. This is C++ code (part of a commit/merge request). --

I like seeing the gitlab activity. It lets me know what new features/fixes are in development and when the time is ripe to pull down the new code and compile.

|01bobbobbobbob|09bob|03bob|11bob|03bob|09bob|01bobbobbob |01robrobrobrob|09rob|03rob|11rob|03rob|09rob|01robrobrob
|07




... Tolkien is hobbit-forming.

---
þ Synchronet þ Halls of Valhalla =San=Francisco= Happy Holidays
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

https://gitlab.synchro.net/main/sbbs/-/merge_requests/56#note_1194

Okay, this is good. We'll set this value to false in the sbbs.ini in Git and that way new sysops should just need to set this one option to true after installing DOSemu. Easy.
--- SBBSecho 3.11-Linux
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

https://gitlab.synchro.net/main/sbbs/-/merge_requests/56#note_1195

I agree with Nelgin on this, just name the file dosemu.conf since that's the common name.
--- SBBSecho 3.11-Linux
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

https://gitlab.synchro.net/main/sbbs/-/merge_requests/56#note_1196

Can we just call this file dosemu.ini?
--- SBBSecho 3.11-Linux
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

https://gitlab.synchro.net/main/sbbs/-/merge_requests/56#note_1197

Huh? What's that mean? If I insert the line "blah=true", it's going to be used? I don't think so.
--- SBBSecho 3.11-Linux
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

https://gitlab.synchro.net/main/sbbs/-/merge_requests/56#note_1198

Did you mean say .ini here (not .bat)?And let's call them "doors" or "external programs" since not all external programs are "games".
--- SBBSecho 3.11-Linux
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

https://gitlab.synchro.net/main/sbbs/-/merge_requests/56#note_1199

How about "path to Synchronet ctrl directory"? Just repeating the variable name with a space doesn't add any value.
--- SBBSecho 3.11-Linux
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

https://gitlab.synchro.net/main/sbbs/-/merge_requests/56#note_1200

By "standard" I think you mean COM/UART/FOSSIL I/O external programs. They're really no more standard than "standard I/O" doors, just more common.
--- SBBSecho 3.11-Linux
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

https://gitlab.synchro.net/main/sbbs/-/merge_requests/56#note_1201

Let's not call them "games".
--- SBBSecho 3.11-Linux
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

https://gitlab.synchro.net/main/sbbs/-/merge_requests/56#note_1202

This needs to be conditional on DOSemu being enabled. If Linux and not DOSemu enabled, then no DOS support.
--- SBBSecho 3.11-Linux
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

https://gitlab.synchro.net/main/sbbs/-/merge_requests/56#note_1203

Ideally, you wouldn't be repeating string constants like "external.bat" - you'd define a char* constant instead and use it (look-up the the DRY principle). It's not a big deal however, just a nit.
--- SBBSecho 3.11-Linux
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

https://gitlab.synchro.net/main/sbbs/-/merge_requests/56#note_1204

another "external.bat" repeated here. See what I mean?
--- SBBSecho 3.11-Linux
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

https://gitlab.synchro.net/main/sbbs/-/merge_requests/56#note_1205

Just a head's up: this is a long unused program. I'll likely just remove it from the repo after this merges.
--- SBBSecho 3.11-Linux
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

Re: Improvements to linux dosemu support
By: Rob Swindell to GitLab note in main/sbbs on Tue Dec 15 2020 01:07 am

https://gitlab.synchro.net/main/sbbs/-/merge_requests/56#note_1205

GitLab Comments/Reviews on merge requests should be posted in the Sync (C/C++) Programming sub from here on.
--
digital man

Synchronet "Real Fact" #81:
Vertrauen has had the FidoNet node number 1:103/705 since 1992.
Norco, CA WX: 52.1øF, 45.0% humidity, 2 mph WSW wind, 0.02 inches rain/24hrs --- SBBSecho 3.11-Linux
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)